<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 26, 2015 at 1:37 PM, Pierre-Yves David <span dir="ltr"><<a href="mailto:pierre-yves.david@ens-lyon.org" target="_blank" class="cremed">pierre-yves.david@ens-lyon.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><br>
<br>
On 05/26/2015 01:07 PM, Matt Mackall wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
# HG changeset patch<br>
# User Matt Mackall <<a href="mailto:mpm@selenic.com" target="_blank" class="cremed">mpm@selenic.com</a>><br>
# Date 1432333213 18000<br>
# Fri May 22 17:20:13 2015 -0500<br>
# Node ID 8e4a41b04eb9373da8c3639edfb060187465809c<br>
# Parent da0105aee52a058e03db3e9c9a187962efc0c7db<br>
color: add default colors for draft and secret changes<br>
<br>
This highlights the changeset number in logs and summary. Together<br>
with log -G, it gives a visual indication of which portions of your<br>
repo are in which phase.<br>
<br>
I've chosen draft = magenta and secret = red. Public changesets<br>
currently automatically use yellow today. There are basically no<br>
"good" color choices available in this palette (I have to squint at<br>
most of them), so I'm not going to belabor the selection process.<br>
<br>
diff -r da0105aee52a -r 8e4a41b04eb9 hgext/color.py<br>
--- a/hgext/color.py Fri May 22 17:08:59 2015 -0500<br>
+++ b/hgext/color.py Fri May 22 17:20:13 2015 -0500<br>
@@ -78,8 +78,8 @@<br>
<br>
# Blank so it inherits the style of the surrounding label<br>
changeset.public =<br>
- changeset.draft =<br>
- changeset.secret =<br>
+ changeset.draft = magenta<br>
+ changeset.secret = red<br>
</blockquote>
<br></div></div>
I think we should keep 'red' for stronger message.<br>
<br>
1) I've been using 'red' for 'troubled' changeset at Facebook with significant success (and grey for obsolete one)<br>
<br>
2) I've some experiment laying around to have all stderr output 'yellow' and actual error message (like abort) 'red'<br>
<br>
What about:<br>
<br>
public: yellow<br></blockquote><div><br></div><div>Not everyone uses a black background (I don't understand why not, but..); yellow is essentially unreadable on white background. The standard blue is too dark on black backgrounds, the standard yellow is too light on white backgrounds. The 'safe' colors in the 16 normally representable that I've encountered are:</div><div><br></div><div>bright black</div><div>red and bright red</div><div>green and bright green</div><div>dark yellow (aka brown)</div><div>magenta and bright magenta</div><div>cyan and bright cyan</div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
draft: magenta<br>
secret: cyan or blue<br>
<br>
(blue is often miss rendered as to dark by mac)<span class="HOEnZb"><font color="#888888"><br>
<br>
<br>
<br>
<br>
-- <br>
Pierre-Yves David</font></span><div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
Mercurial-devel mailing list<br>
<a href="mailto:Mercurial-devel@selenic.com" target="_blank" class="cremed">Mercurial-devel@selenic.com</a><br>
<a href="https://selenic.com/mailman/listinfo/mercurial-devel" target="_blank" class="cremed">https://selenic.com/mailman/listinfo/mercurial-devel</a><br>
</div></div></blockquote></div><br></div></div>