<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Sep 9, 2014, at 12:34 PM, David Soria Parra <<a href="mailto:davidsp@fb.com">davidsp@fb.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br><br>Am 9/9/14, 8:57 AM, schrieb Augie Fackler:<br><blockquote type="cite">On Mon, Sep 08, 2014 at 09:35:54AM -0700, David Soria Parra wrote:<br><blockquote type="cite"># HG changeset patch<br># User David Soria Parra <<a href="mailto:davidsp@fb.com">davidsp@fb.com</a>><br># Date 1409941197 -7200<br># Fri Sep 05 20:19:57 2014 +0200<br># Node ID e79544cdfb81f88d782e923d96e8ad63303aec94<br># Parent c4b1d0db14c257e9fbb58e0f044c28f12dade3dd<br>histedit: add stop verb<br><br>We are adding a 'stop' verb for histedit. This applies the changes<br>and drops the user into a shell after committing the changes. This allows to<br>amend or modify the commit with external tooling. However, as a changeset can<br>have potential children which would dissallow amending, we have to recreate the<br>commit and therefore all hashes after a first stop are changing.<br></blockquote><br>What happens if I do 'stop' but don't make changes? Does the user get<br>to retain the original, non-fussed-with hash?<br><br>(I'm not 100% sure it's a showstopper if the answer is "no", but I'd<br>really like the answer to be "yes".)<br></blockquote><br>The answer here is "no". When we are recreating the node, we are getting<br>a new hash. We would need to be able to compare afterwards if the new<br>node and the original node "match", consdering they have different<br>hashes. As far as I can tell we don't have any way to do that at the<br>moment, so I opted that we always recreate the node if you use stop and<br>have obsolence markers disabled.<br></div></blockquote><div><br></div><div>Could you compare the manifest node? Would that always be the same?</div><br><blockquote type="cite"><div style="font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>- David</div></blockquote></div><br></body></html>