<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 20/02/13 01:42, Siddharth Agarwal
wrote:<br>
</div>
<blockquote cite="mid:51242A22.2090608@fb.com" type="cite">On
02/19/2013 01:11 AM, Steve Barnes wrote:
<br>
<blockquote type="cite">
<br>
# HG changeset patch
<br>
<br>
# User Steve Barnes <a class="moz-txt-link-rfc2396E" href="mailto:gadgetsteve@hotmail.com"><gadgetsteve@hotmail.com></a>
<br>
<br>
# Date 1361263154 0
<br>
<br>
# Node ID 97b7c13ff8173c257143b9bcabb8ad726ade98cc
<br>
<br>
# Parent 5fe53db61aa433018de8b0ee296db868f666cee7
<br>
<br>
util: cope with missing subprocess.startf_useshowwindow in
python 2.6.x on nt (issue3832)
<br>
<br>
</blockquote>
<br>
This is too long. I'd suggest something like
<br>
<br>
"util: hardcode STARTF_USESHOWWINDOW"
<br>
<br>
with a note in the full message explaining why (it isn't present
in some newer versions of Python).
<br>
<br>
<blockquote type="cite">- startupinfo.dwFlags |=
subprocess.STARTF_USESHOWWINDOW
<br>
<br>
+ if hasattr(subprocess, 'STARTF_USESHOWWINDOW'): # Not all
pythons have this
<br>
<br>
+ startupinfo.dwFlags |= subprocess.STARTF_USESHOWWINDOW
<br>
<br>
</blockquote>
<br>
Why not just hardcode the value? That's 1 according to
<a class="moz-txt-link-freetext" href="http://msdn.microsoft.com/en-us/library/windows/desktop/ms686331%28v=vs.85%29.aspx">http://msdn.microsoft.com/en-us/library/windows/desktop/ms686331%28v=vs.85%29.aspx</a>.<br>
<br>
<br>
</blockquote>
Personally I am never comfortable with adding mystery hard coded
values nor with sending undocumented - as in not a part of the user
interface flags to a library call. The way that I suggested will
use the flag as it is if it available and ignore it if it is not.
Just my 2c worth.<br>
<br>
Steve<br>
<br>
<div class="moz-signature">-- <br>
Steve <i>Gadget</i> Barnes</div>
</body>
</html>