<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Jun 13, 2012, at 2:28 PM, Matt Mackall wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>On Wed, 2012-06-13 at 12:42 -0500, Kevin Bullock wrote:<br><blockquote type="cite">On Jun 11, 2012, at 5:37 PM, Matt Mackall wrote:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><blockquote type="cite">On Fri, 2012-06-08 at 14:42 -0500, Kevin Bullock wrote:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">* Warn (with hint) when pushing changesets that are bookmarked<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">without pushing the bookmarks (suggested by [[marmoute]]:<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><a href="http://markmail.org/message/pxemyessq6ek7ynw">http://markmail.org/message/pxemyessq6ek7ynw</a>).<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">I don't think a warning is sufficient. Given our non-existent<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">support<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">for unpushing, this warning will usually translate as "you idiot,<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">you<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">just pushed the code you were trying to keep local".<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Sometimes our "no new heads" restriction will prevent this class of<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">accident, but I think we should aim to do it more generally.<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">If it's more than a warning, then I can't keep a local-only bookmark<br></blockquote><blockquote type="cite">on public changesets.<br></blockquote><br>Sure you can, they just can't be heads. If they're on heads, you'll need<br>to bypass the check.<br></div></blockquote><div><br></div><div>So you're suggesting that if my 'already-reviewed' bookmark is on a head, and I don't want to share that bookmark, I'll have to 'push --force'?</div></div><br><div>
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="orphans: 2; text-align: -webkit-auto; text-indent: 0px; widows: 2; -webkit-text-decorations-in-effect: none; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">pacem in terris / мир / शान्ति / سَلاَم / 平和</div><div style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Kevin R. Bullock<br></div></span></span>
</div>
<br></body></html>