<html><body>
<p>Benoit,<br>
<br>
It is a little strange to specify --ssh=rsh ssh://host/path... Isn't it much more precise and consistent to<br>
just use rsh://host/path?<br>
<br>
Nevertheless, I can work on submission of a patch that will have --ssh override the *sh:// specification,<br>
if there is any chance of getting it in the mainline.<br>
<br>
Regards,<br>
<br>
Pjotr<br>
<img src="cid:10__=4EBBFEDCDFAA39788f9e8a93df938690@nxp.com" width="16" height="16" alt="Inactive hide details for "Benoit Boissinot" <bboissin@gmail.com>">"Benoit Boissinot" <bboissin@gmail.com><br>
<br>
<br>
<table width="100%" border="0" cellspacing="0" cellpadding="0">
<tr valign="top"><td style="background-image:url(cid:20__=4EBBFEDCDFAA39788f9e8a93df938690@nxp.com); background-repeat: no-repeat; " width="40%">
<ul><b><font size="2">"Benoit Boissinot" <bboissin@gmail.com></font></b><font size="2"> </font>
<p><font size="2">05/20/2008 12:02 PM</font></ul>
</td><td width="60%">
<table width="100%" border="0" cellspacing="0" cellpadding="0">
<tr valign="top"><td width="1%" valign="middle"><img src="cid:30__=4EBBFEDCDFAA39788f9e8a93df938690@nxp.com" border="0" height="1" width="58" alt=""><br>
<div align="right"><font size="2">To</font></div></td><td width="100%"><img src="cid:30__=4EBBFEDCDFAA39788f9e8a93df938690@nxp.com" border="0" height="1" width="1" alt=""><br>
<font size="2">"Pjotr Kourzanov" <peter.kourzanov@xs4all.nl></font></td></tr>
<tr valign="top"><td width="1%" valign="middle"><img src="cid:30__=4EBBFEDCDFAA39788f9e8a93df938690@nxp.com" border="0" height="1" width="58" alt=""><br>
<div align="right"><font size="2">cc</font></div></td><td width="100%"><img src="cid:30__=4EBBFEDCDFAA39788f9e8a93df938690@nxp.com" border="0" height="1" width="1" alt=""><br>
<font size="2">"Pjotr Kourzanov" <peter.kourzanov@nxp.com>, mercurial-devel@selenic.com</font></td></tr>
<tr valign="top"><td width="1%" valign="middle"><img src="cid:30__=4EBBFEDCDFAA39788f9e8a93df938690@nxp.com" border="0" height="1" width="58" alt=""><br>
<div align="right"><font size="2">Subject</font></div></td><td width="100%"><img src="cid:30__=4EBBFEDCDFAA39788f9e8a93df938690@nxp.com" border="0" height="1" width="1" alt=""><br>
<font size="2">Re: [PATCH] Updated *sh://host... patch</font></td></tr>
</table>
<table border="0" cellspacing="0" cellpadding="0">
<tr valign="top"><td width="58"><img src="cid:30__=4EBBFEDCDFAA39788f9e8a93df938690@nxp.com" border="0" height="1" width="1" alt=""></td><td width="336"><img src="cid:30__=4EBBFEDCDFAA39788f9e8a93df938690@nxp.com" border="0" height="1" width="1" alt=""></td></tr>
</table>
</td></tr>
</table>
<br>
<tt>2008/3/21 Pjotr Kourzanov <peter.kourzanov@xs4all.nl>:<br>
> Patch subject is complete summary.<br>
><br>
><br>
> 2 files changed, 14 insertions(+), 8 deletions(-)<br>
> mercurial/hg.py | 9 +++++++--<br>
> mercurial/sshrepo.py | 13 +++++++------<br>
><br>
<br>
(Can you try to send the messages inline ?)<br>
<br>
About your patch, is there a reason why you can't use the --ssh<br>
(or ui.ssh in .hgrc) option ?<br>
<br>
> - sshcmd = self.ui.config("ui", "ssh", "ssh")<br>
> + # TODO bogus: sshcmd = self.ui.config("ui", "ssh", "ssh")<br>
> + sshcmd = m.group(1)<br>
In any case if this patch goes in, it needs to continue to support --ssh.<br>
<br>
regards,<br>
<br>
Benoit<br>
</tt><br>
</body></html>