Code review/Feedback needed for new extension
redhotsly at hotmail.com
Thu May 6 23:06:36 CDT 2010
Thanks a lot for the feedback. I fixed most issues you reported except:
> I think macros should just create new commands, like alias does.
I know...that's issue #1 in my issues list. I have to read the alias extension code to see how they do it. For now you can define an alias to a macro:
pullupdate=hg macro pullupdate
> Why all the whitespace? Nobody puts that many blank lines in real config files, so there's no need for them in the help.
If I remove the whitespace in the docstring, then, on my Windows 7 PC, if I run
hg help macros
The help output is all on the same line:
[macros] supermacro=log -l 5;stat purgex=revert -a;purge
I have to double all line breaks in the docstring to get `hg help` to output the right thing.
> Anyways: this looks interesting. Keep at it!
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Mercurial-devel