In main, resolving.

I've pushed the typo fix:

changeset:   7195:9fabcb1fe68d
tag:         tip
user:        Christian Ebert <blacktrash@gmx.net>
date:        Tue Oct 21 10:29:57 2008 +0200
summary:     mail: correct typo in variable name

Thanks!

Typo fix: http://www.selenic.com/pipermail/mercurial-devel/2008-
October/008588.html

Your newest patches are now in crew

ThomasAH,

Some questions to your answers ;-)

With locales you mean that besides decode/encode(utf-8) I should also check for 
util._encoding == utf-8? Or do you just mean that I shouldn't try other 
charsets? Concerning the latter: I won't; even like this there are risks like 
broken decoding functions in receiving client etc.

base64: that's what python's email module does by default, but it can be set 
explicitly. If I do that, I don't think an additional test is needed.

If you could clarify then I can send updated patches later today.

I think I like those two patches waiting in your queue.

Some answers to your questions in the patch headers:
- Do not try other locales besides utf-8, because this would be too much
guessing as patches could even contain different encodings per line.
- I prefer base64 encoding as this can easily be extraced from a raw mail and be
applied using 'patch'. With a QP encoded patch with only few 8bit chars you
could very easily miss those, pipe the raw mail to 'patch' and get a broken file.

So with the questions in the commit message changed to statements I'd like to
hae these two applied in general. Could you provide a small automatic test for
these?

Hm, not exactly, as the submitter also wanted *patch* data encoded.

I have 2 more patches that do that for "pure" utf-8 patches. I was reluctant to 
resubmit them as touching patch data might be too risky.

Can again post them to devel so a policy concerning this can be decided. 
Meanwhile they're also at http://www.blacktrash.org/hg/hg-queue/.

These patches are now in the main repository (ceb8aef03aa7 and its parents)

I've submitted my patches to mercurial-devel again.

imho an otherwise elegant program should not cripple people's
names. Email is not about machine-readability. Which is why I am
proposing a less slim solution.

Also forcing users to keep their commit messages in ascii is a
showstopper for projects that do not deal with code.

At least I got some "normal" users to cooperate with me thanks to
these patches ;)

What's the status here? I've also discovered

  http://marc.info/?t=118443241700002&r=1&w=2

which is an earlier, much simpler, attempt at this, with a response from mpm, a
reply, then nothing.

I've just verified that this bug seems still present with mercurial 1.0

i made a patch queue against crew available at
http://www.blacktrash.org/hg/hg-mail-mq/
in case anyone wants to try, comment, improve.

crew repo with rebased queue at
http://www.blacktrash.org/hg/hg-crew-mq/

i've submitted a rough sketch to deal with this and other stuff
(wrong issue number) at: 
http://www.selenic.com/pipermail/mercurial-devel/2008-February/004933.html ff.
actually for utf-8 it's easy (5. patch).

c

Hi,

  This is the Debian bug #427854 ( http://bugs.debian.org/427854 )
The submitter is working on it upstream. It is still present in 0.9.5

  Best regards,
    Vincent

Wesley J. Landaker wrote:
> Package: mercurial
> Version: 0.9.3-2
> Severity: normal
> 
> hg email (the patchbomb extension) doesn't send patches encoded
> properly. Everything in my repo is UTF-8, and I am running with a UTF-8
> locale, and all the default encoding stuff for mercurial is set to fall
> back to UTF-8, etc.
> 
> However, when I send a patch (of a UTF-8 file) the mail header has:
> 
> Content-Type: text/plain;
>   charset="us-ascii"
> 
> This of course totally breaks the patch for the recipient, unless they
> know how to manually work around it.
> 
> 
> -- System Information:
> Debian Release: lenny/sid
>   APT prefers unstable
>   APT policy: (500, 'unstable'), (40, 'experimental')
> Architecture: i386 (i686)
> 
> Kernel: Linux 2.6.20 (SMP w/2 CPU cores; PREEMPT)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/bash
> 
> Versions of packages mercurial depends on:
> ii  libc6                         2.5-10     GNU C Library: Shared libraries
> ii  python                        2.4.4-6    An interactive high-level object-o
> ii  python-support                0.6.4      automated rebuilding support for p
> ii  python2.4                     2.4.4-4    An interactive high-level object-o
> 
> Versions of packages mercurial recommends:
> pn  kdiff3 | tkdiff | rcs         <none>     (no description available)
> pn  tk8.4 | wish                  <none>     (no description available)
> 
> -- no debconf information
>