Issue1286

Title hg normalization performance on Win32 (case folding systems)
Priority bug Status resolved
Superseder Nosy List abuehl, djc, pko, tksoh, tonfa
Assigned To Topics patch, windows

Created on 2008-09-03.19:33:51 by pko, last changed 2008-10-09.08:33:55 by djc.

Files
File name Uploaded Type Edit Remove
issue_1286.patch pko, 2008-10-03.18:50:32 application/octet-stream
Messages
msg7349 (view) Author: djc Date: 2008-10-09.08:33:55
Fixed in 57377fa7eda2, in main. Resolving.
msg7303 (view) Author: pko Date: 2008-10-03.18:50:32
This should be a simple patch to eliminate the problem. Basic idea - if the path
is known to be result of recursive tree walk than do not call the fspath - we
already have fspath in that case.
msg6932 (view) Author: pko Date: 2008-09-03.19:33:50
under some circumstances the path normalization causes very slow repo operations 

example: hg init in large repository immediately followed by hg stat 

the problem is that foldmaps are empty for freshly initialized repositories so
the normalize call in dirstat that is normally used for each file in the repo 
will always call the util.fspath for each file 

given that the work list is result of path scanning the normalization and
additional lookups should not be required 

proposed patch is attached  
on ~30k files this accelerates the hg init/hg stat sequence from 20s to .56s
History
Date User Action Args
2008-10-09 08:33:55djcsetstatus: chatting -> resolved
nosy: + djc
messages: + msg7349
2008-10-03 18:50:32pkosetfiles: + issue_1286.patch
messages: + msg7303
2008-10-03 18:43:31pkosetmessages: - msg6936
2008-10-03 18:43:25pkosetmessages: - msg6935
2008-10-03 18:43:13pkosetmessages: - msg6933
2008-10-03 18:43:01pkosetmessages: - msg6934
2008-10-03 18:42:51pkosetmessages: - msg6937
2008-10-03 18:42:33pkosetmessages: - msg6953
2008-09-05 15:23:46pkosetpriority: wish -> bug
2008-09-05 15:23:38pkosetfiles: - unnamed
2008-09-05 15:23:35pkosetfiles: - unnamed
2008-09-05 15:23:30pkosetfiles: - patch_1286.txt
2008-09-05 15:23:26pkosetfiles: - no_normalization.txt
2008-09-05 15:23:17pkosetmessages: + msg6953
2008-09-04 13:06:42tksohsetnosy: + tksoh
2008-09-03 21:01:41pkosetfiles: + unnamed
messages: + msg6937
2008-09-03 20:50:58tonfasetmessages: + msg6936
2008-09-03 20:39:46pkosetfiles: + patch_1286.txt
messages: + msg6935
2008-09-03 20:26:40pkosetfiles: + unnamed
messages: + msg6934
2008-09-03 20:05:23abuehlsetnosy: + abuehl
2008-09-03 19:52:22tonfasetstatus: unread -> chatting
messages: + msg6933
2008-09-03 19:50:43tonfasettopic: + windows, patch
nosy: + tonfa
2008-09-03 19:33:51pkocreate