Issue1259

Title notify::diff() leads to erroneous diffstat by adding extra empty lines
Priority bug Status resolved
Superseder Nosy List abuehl, divy, djc, tonfa
Assigned To Topics patch

Created on 2008-08-13.06:26:06 by divy, last changed 2008-10-10.18:58:06 by tonfa.

Files
File name Uploaded Type Edit Remove
patch_notify.patch divy, 2008-08-13.06:38:40 text/x-diff
Messages
msg7395 (view) Author: divy Date: 2008-10-10.18:49:32
Thanks for applying the patch.
Sorry the late reply.
msg7129 (view) Author: djc Date: 2008-09-15.08:08:15
In main, resolving.
msg6923 (view) Author: tonfa Date: 2008-09-03.00:05:02
Thanks for this.

I modified it slightly, and pushed it to crew (a3fd4aa154af). I hope you don't
mind that I didn't push the original but didn't modify the author.
msg6759 (view) Author: divy Date: 2008-08-13.06:57:33
I'm updating the status to reflect the proposed patch.
The patch is built against the main repository, it applies cleanly to the crew 
repo.
msg6758 (view) Author: divy Date: 2008-08-13.06:38:40
Resubmitting the proposed patch, used white spaces instead of tabs.
msg6757 (view) Author: divy Date: 2008-08-13.06:26:05
notify::diff() keeps line breaks in the diff buffer before calling
patch::diffstat().
patch::diffstat() adds another line break when feeding diffstat input.
This combination results in an extra empty line in diffstat input, leading to 
erroneous diffstat output.
To reproduce: a one line diff in a file is most of the time ignored (diffstat 
outputs '0 file changed'), the stats are otherwise inaccurate.
The proposed patch in attachment the line breaks in notify::diff() and loops 
through the diff lines to print them.

Cheers,
Divy
History
Date User Action Args
2008-10-10 18:58:06tonfasetstatus: chatting -> resolved
2008-10-10 18:49:32divysetstatus: resolved -> chatting
messages: + msg7395
2008-09-15 08:08:15djcsetstatus: testing -> resolved
nosy: + djc
messages: + msg7129
2008-09-03 00:05:03tonfasetstatus: in-progress -> testing
messages: + msg6923
2008-09-02 23:36:42tonfasetnosy: + tonfa
2008-08-13 07:37:52abuehlsettopic: + patch
nosy: + abuehl
2008-08-13 06:57:33divysetstatus: chatting -> in-progress
messages: + msg6759
2008-08-13 06:38:40divysetfiles: + patch_notify.patch
status: unread -> chatting
messages: + msg6758
2008-08-13 06:37:12divysetfiles: - patch_notify.patch
2008-08-13 06:26:06divycreate